Verify that files generated with SwiftSyntaxBuilder match the checked-in state #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
ahoppen/verify-codegened-files
branch
from
09d75c8 to
c0567a8
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/verify-codegened-files
branch
from
c0567a8 to
fdcb9ee
Compare
…-in state "Currently, we only verify that the gyb-generated files match the checked in source state. As more and more files are being generated using CodeGeneration, we should also verify them in CI. rdar://103023853
ahoppen
force-pushed
the
ahoppen/verify-codegened-files
branch
from
fdcb9ee to
1f82dd4
Compare
|
@swift-ci Please test |
kimdv
approved these changes
Dec 8, 2022
ahoppen
changed the title
|
@swift-ci Please test |
|
Closing in favor of #1546 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we only verify that the gyb-generated files match the checked in source state. As more and more files are being generated using CodeGeneration, we should also verify them in CI.
rdar://103023853